Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated lcdd() from GeoSvc Interface #176

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Remove the deprecated lcdd() from GeoSvc Interface #176

merged 2 commits into from
Feb 22, 2024

Conversation

kjvbrt
Copy link
Contributor

@kjvbrt kjvbrt commented Feb 8, 2024

BEGINRELEASENOTES

  • Remove the deprecated lcdd() from GeoSvc Interface

ENDRELEASENOTES

@kjvbrt
Copy link
Contributor Author

kjvbrt commented Feb 8, 2024

I already merged HEP-FCC/k4SimGeant4#58

@jmcarcell
Copy link
Contributor

The downstream-build workflow is failing because lcdd is still used by the dual-readout repo

@kjvbrt
Copy link
Contributor Author

kjvbrt commented Feb 9, 2024

Reverting HEP-FCC/k4SimGeant4#58 for now.

@kjvbrt
Copy link
Contributor Author

kjvbrt commented Feb 22, 2024 •
edited
Loading

Removing lcdd() from k4SimGeant4 again. Downstream test should pass now.
HEP-FCC/k4SimGeant4#66

@jmcarcell
Copy link
Contributor

This looks fine now, some tests fail in fccsw but they are broken because of other reasons

@jmcarcell jmcarcell merged commit 725e35b into key4hep:main Feb 22, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvbrt @jmcarcell