Add an argument for add_test_with_env not to have to repeat the test names #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to move |
jmcarcell
force-pushed
the
test-cmake
branch
from
f3a5d70
to
480c1db
Compare
|
Makes sense but we install the whole scripts folder, which I don't think it's a bad idea, and then this file would also be installed. I think it's fine as it is since it's only a folder for tests. |
|
Sorry I meant to |
|
Yes, moved. |
jmcarcell
force-pushed
the
test-cmake
branch
from
12cb6de
to
b73e17a
Compare
test names. Also add some documentation for the function since it's getting complicated.
jmcarcell
force-pushed
the
test-cmake
branch
from
b73e17a
to
a35cfb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
No more endless horizontal scrolling