Fix histograms for Gaudi v39 and add a configurable histogram #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The upcoming version of Gaudi is v39 |
|
True, fixed |
jmcarcell
changed the title
jmcarcell
added a commit
to key4hep/k4Reco
that referenced
this pull request
Sep 22, 2024
RootHistogram has been renamed to StaticHistogram, see key4hep/k4FWCore#239
tmadlener
reviewed
Sep 23, 2024
| public: | ||
| #if GAUDI_MAJOR_VERSION >= 39 | ||
| // This is a histogram with title, name and bins that can be set from python | ||
| void registerCallBack(Gaudi::StateMachine::Transition, std::function<void()>) {} |
There was a problem hiding this comment.
I suppose this is necessary for any algorithm that has histograms? In that case we need to document it.
There was a problem hiding this comment.
This is necessary for histograms with configurable properties, I added a comment about that (so the ones that are not Static...).
|
Works for me against v39r0 locally. Anything still missing for this? |
|
Nothing missing, there is one histogram in k4RecTracker that you found and I think some in one PR in k4GaudiPandora and that should be all left. I'll enable auto-merge. |
jmcarcell
force-pushed
the
fix-histogram
branch
from
3b7f52d
to
684050e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
StaticRootHistogramfromRootHistogramRootHistogram, whose bins, title and other properties can be set from python as shown in the test fileENDRELEASENOTES