Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant inline #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove redundant inline #248

wants to merge 1 commit into from

Conversation

jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

  • Remove redundant inline, constexpr implies inline

ENDRELEASENOTES

@m-fila m-fila mentioned this pull request Oct 9, 2024
Merged
@m-fila
Copy link
Contributor

m-fila commented Oct 16, 2024

As far as I understand the inline here is not redundant as it's templated, non-static, non-member, constexpr object declaration. And it's in header so it's potentially useful and at least not harmful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @m-fila