Use std::unique_ptr<podio::CollectionBase> to save collections in the store and fix leak in the Writer
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Oct 10, 2024
k4FWCore/components/Writer.cpp
Outdated
| @@ -263,6 +266,9 @@ class Writer final : public Gaudi::Functional::Consumer<void(const EventContext& | |||
|
|
|||
| debug() << "Writing frame" << endmsg; | |||
| iosvc->getWriter().writeFrame(ptr->getData(), podio::Category::Event, m_collectionsToSave); | |||
| if (deletePtr && m_collectionsToAdd.empty()) { | |||
There was a problem hiding this comment.
Why is the condition here also checking the m_collectionsToAdd to be empty?
jmcarcell
changed the title
std::unique_ptr<podio::CollectionBase> to save collections in the store and fix leak in the Writer
… store Also fix a leak in the Writer that without this change would have been difficult to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #249 for the report of the leak.
BEGINRELEASENOTES
std::unique_ptr<podio::CollectionBase>for the collections in the store instead ofstd::shared_ptr<podio::CollectionBase>.Writerthat otherwise would have been difficult to fixFunctionalUtils.h: remove some unused overloads and change some names.ENDRELEASENOTES
shared_ptrwas supposed to be temporary until everything worked, so it was a good time to remove it.