Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workarounds for catching non-zero exit codes #140

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Remove workarounds for catching non-zero exit codes #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions doc/starterkit/k4MarlinWrapperCLIC/CEDViaWrapper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,9 @@ With all these pieces put together (as in `examples/event_display.py`) it is now
```bash
glced &

k4run $K4MARLINWRAPPER/examples/event_display.py --EventDataSvc.input=gamma_10GeV_edm4hep.root || true
k4run $K4MARLINWRAPPER/examples/event_display.py --EventDataSvc.input=gamma_10GeV_edm4hep.root
```

Note that we silence the exit code of `k4run` to work around a [framework
issue](https://github.com/key4hep/k4FWCore/issues/125). This is usually not
necessary if you run things interactively.

## Creating a Gaudi options file

The `event_display.py` options file that is used above and that is present in the examples has been produced following these steps:
Expand Down
8 changes: 1 addition & 7 deletions doc/starterkit/k4MarlinWrapperCLIC/Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,19 +143,13 @@ included with k4MarlinWrapper. Note that:
+ Change the line where `evtsvc.input` is defined to point to the location of your input file.
+ At the bottom of the file, in the `ApplicationMgr` parameters, change `EvtMax = 3,` to the number of events to run.

This can be run in the following way. Note that we show the usage here in a way
that also works in scripts with `-e` enabled. This is necessary because of a
[framework issue](https://github.com/key4hep/k4FWCore/issues/125) that makes
`k4run` exit with a non-zero exit code even though nothing went wrong.

This can be run in the following way.
```bash
cd CLICPerformance/clicConfig

cp $K4MARLINWRAPPER/examples/clicRec_e4h_input.py .

k4run clicRec_e4h_input.py --EventDataSvc.input ttbar_edm4hep.root
result=$?
[ $result = "0" ] || [ $result = "4" ] && true
```

### DD4hep Geometry Information
Expand Down
Loading