Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use GaudiAlg #165

Merged
merged 14 commits into from
Jul 29, 2024
Merged

Don't use GaudiAlg #165

merged 14 commits into from
Jul 29, 2024

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Jan 23, 2024

BEGINRELEASENOTES

  • Change headers and add EventContext in algorithms not to use GaudiAlg
  • Replace GaudiTool with AlgTool

ENDRELEASENOTES

@andresailer
Copy link
Collaborator

This is still work in progress or depend on some other PR?

@jmcarcell
Copy link
Contributor Author

This should now be ready, finally the build is passing

@jmcarcell jmcarcell changed the title Don't use GaudiAlg (first part) Don't use GaudiAlg Jul 27, 2024
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I have to understand why AlgTool is the non-deprecated on while GaudiTool is? ;)

This looks fairly complete now, or is there still something missing?

@jmcarcell
Copy link
Contributor Author

jmcarcell commented Jul 29, 2024

Do I have to understand why AlgTool is the non-deprecated on while GaudiTool is? ;)

GaudiTool is in GaudiAlg 😄
I think there are a few differences like AlgTool not accessing the data store directly. In general I think we use few things of the class and we could probably get by with a minimal implementation of IAlgTool.

This looks fairly complete now, or is there still something missing?

It's ready, I don't think anything needs to be changed unless we find issues but the tests are passing.

@jmcarcell jmcarcell merged commit 63eee6f into main Jul 29, 2024
8 of 11 checks passed
@jmcarcell jmcarcell deleted the gaudialg branch July 29, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants