Retrieve B field and detector info in TracksFromGenParticlesWithECalExtrap functional

[giovannimarchiori]

add retrieval of B field and extrapolation to calorimeter to functional that produces tracks from gen particles.
Based on transformer code from TracksFromGenParticles.cpp and on detector retrieval and extrapolation code from [racksFromGenParticlesWithECalExtrapAlg.cpp.

BEGINRELEASENOTES

• add retrieval of B field and extrapolation to calorimeter to functional that produces tracks from gen particles
  ENDRELEASENOTES

[giovannimarchiori]

rebased

[atolosadelgado]

hi @giovannimarchiori

Thanks for this PR! I’m curious, am I correct in understanding that the main difference from the algorithm introduced three weeks ago is that the previous one was a Gaudi algorithm, while this PR introduces the same functionality as a Gaudi functional?

If that’s the case, do you think it would be beneficial to wrap the core logic of the Gaudi algorithm into a dedicated class? That way, we could avoid code duplication.

Thanks again for your work!

[giovannimarchiori]

Hi @atolosadelgado,
before doing that - is there a reason on the long term to keep both versions? If at some point the Gaudi::Algorithm should just be phased out, then I am not sure it's worth spending time refactoring the code.
I don't know the answer myself, just let me know

[atolosadelgado]

Hi @atolosadelgado, before doing that - is there a reason on the long term to keep both versions? If at some point the Gaudi::Algorithm should just be phased out, then I am not sure it's worth spending time refactoring the code. I don't know the answer myself, just let me know

As in the TV show 'who wants to be a millionaire', I will play the joker card 'phone a friend': @BrieucF @kjvbrt @jmcarcell , do you think it is worth to refactor code, or it is ok to duplicate it as Gaudi algorithm is going to be deprecated in the near future?

[atolosadelgado]

So @BrieucF told me privately to merge, but please do not forget to remove the Gaudi::Algorithm once we are 'migrated' to functionals and Gaudi::Algorithm is phased out.

The CI test in ubuntu are failing [link]. It seems related to the EDM4hep data extension for the drift chamber. @jmcarcell what do you suggest to do?

[giovannimarchiori]

Hi @atolosadelgado
I created an issue #46 to keep in mind "to remove the Gaudi::Algorithm once we are 'migrated' to functionals and Gaudi::Algorithm is phased out"
Thanks, Giovanni