Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the DDPlanarDigi algorithm to run like the processor #4

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Jul 3, 2024

some things I found when comparing the output histograms.

BEGINRELEASENOTES

  • Change the default value for the time resolution to -1, which will mean no time smearing by default.
  • Use the histogram service to save histograms instead of saving our own files (which meant that if the algorithm runs multiple time there will be multiple files, or a single one if the name is the name for all of them with the content of the last one that was saved).
  • Other minor changes like removing an unnecessary header or changing and to &&.

ENDRELEASENOTES

Change the default value for the time resolution to -1, which will mean no time
smearing by default. Change also the directory of the histograms, since
currently only the histograms for the last collection are saved.
@jmcarcell jmcarcell force-pushed the digi-fixes branch 2 times, most recently from 97ee6e0 to 577851d Compare July 6, 2024 06:22
@jmcarcell
Copy link
Contributor Author

If there aren't any complains, the last time I checked this it seems to be running exactly like the processor, with the only difference that the histograms are saved in alphabetic order in the ROOT file but this is coming from Gaudi.

@jmcarcell jmcarcell merged commit 281b93b into main Jul 7, 2024
5 of 7 checks passed
@jmcarcell jmcarcell deleted the digi-fixes branch July 7, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant