Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a few cmake improvements #111

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Make a few cmake improvements #111

merged 4 commits into from
Sep 12, 2023

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Sep 12, 2023 •
edited
Loading

BEGINRELEASENOTES

  • Fix a cmake warning by changing the minimum version to 3.5, since support for versions < 3.5 is going to be removed in the future
  • Rename the podioDict or edm4hepDict targets to podio or edm4hep in generator expressions for when they will be removed
  • Add ROOT libraries at link time for building k4SimDelphes together with other packages
  • Fix a test because the steering file was missing an import os (behaviour changed after k4run: allow addition of additional parameters from steering files k4FWCore#134)

ENDRELEASENOTES

tmadlener
tmadlener reviewed Sep 12, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
jmcarcell
jmcarcell commented Sep 12, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@jmcarcell jmcarcell merged commit b3e12de into main Sep 12, 2023
8 of 9 checks passed
@jmcarcell jmcarcell deleted the cmake-improvements branch September 12, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener