Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use GaudiAlg, use Gaudi::Algorithm instead #126

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Do not use GaudiAlg, use Gaudi::Algorithm instead #126

merged 4 commits into from
Jul 30, 2024

Conversation

jmcarcell
Copy link
Contributor

These are the changes needed not to use GaudiAlg, which will be removed (maybe soon) in Gaudi.

BEGINRELEASENOTES

  • Do not link to GaudiAlgLib
  • Add the necessary changes to the algorithm, use Gaudi::Algorithm, make execute() const and add a const EventContext&
  • Add mutable to some elements that are changed; add const to some functions so that they can be called inside execute(const EventContext&) const

ENDRELEASENOTES

@jmcarcell jmcarcell merged commit 46af66c into main Jul 30, 2024
7 of 9 checks passed
@jmcarcell jmcarcell deleted the gaudialg branch July 30, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmcarcell