Fix flaky tests by disregarding order of mc-reco links #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
changed the title
andresailer
reviewed
Oct 4, 2024
|
I didn't observe any failures locally with this in 30 repetitions. Given previous experience in #129 I would have expected around 10, so I think this at least fixes the observed failure. |
|
Merging this, then rebasing #128 to get a tag done for the next Key4hep release, unless someone complains in the next hour. |
andresailer
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
- [ ] Needs key4hep/key4hep-actions#7As already stated in the inline comment: Delphes seems to write these in different orders even with the same random seed. It seems to only happen during writing of the Delphes file, as the EDM4hep files that come out of the converter are the same. I have done a
diff <(podio-dump -d -e <offending-event> <run_1.root>) <(podio-dump -d -e <offending-event> <run-2.root>)and that yields no differences in the files apart from the obviously different file names.Given all that, I think this is the most reasonable fix we can make.
Fixes #129