-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a list of charm hadron IDs to the pythiaEvtGen interface #90
base: main
Are you sure you want to change the base?
Conversation
std::vector<int> B_ids; | ||
std::vector<int> C_ids; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::vector<int> B_ids; | |
std::vector<int> C_ids; |
In principle only the Had_ids
are necessary as member variable here, right? The B
and C_ids
seem to be mainly used for initializing that, but nowhere else.
Hi @zuoxunwu, thanks for the PR! Can you check the suggestion by Thomas above? |
Hi @zuoxunwu, did you have time to look into the comment above? Is there anything else missing from your side here? |
@@ -48,6 +48,10 @@ PythiaEvtGen_Interface::PythiaEvtGen_Interface(Pythia8::Pythia* p, std::string p | |||
// int arr[] = {511,521,531,541,5122,5132,5142,5232,5242,5332,5342,5412,5414,5422,5424,5432,5434,5442,5444,5512,5514,5522,5524,5532,5534,5542,5544,5544}; | |||
B_ids = std::vector<int>{511, 521, 531, 541, 5122, 5132, 5142, 5232, 5242, 5332, 5342, 5412, 5414, 5422, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B_ids = std::vector<int>{511, 521, 531, 541, 5122, 5132, 5142, 5232, 5242, 5332, 5342, 5412, 5414, 5422, | |
std::vector<int> B_ids = std::vector<int>{511, 521, 531, 541, 5122, 5132, 5142, 5232, 5242, 5332, 5342, 5412, 5414, 5422, | |
5424, 5432, 5434, 5442, 5444, 5512, 5514, 5522, 5524, 5532, 5534, 5542, 5544, 5544}; | |
std::vector<int> C_ids = std::vector<int>{411, 421, 431, 4122, 4222, 4212, 4112, 4224, 4214, 4114, 4232, 4132, 4322, | |
4312, 4324, 4314, 4332, 4334, 4412, 4422, 4414, 4424, 4432, 4434, 4444}; |
Hi @tmadlener and @vvolkl, Sorry I totally missed the previous notices. Just taking a look. (Just added a declaration, if we remove the Best, |
BEGINRELEASENOTES
Adding a list of charm hadron IDs to the pythiaEvtGen interfaces so the generic non-signal charm decays are handled in EvtGen.
ENDRELEASENOTES
Local tests:
Tested with EvtGen decs for D meson decays. Worked as expected.