Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLD_o2_v07: Fix lumi cal back shield, change envelopes to assemblies #391

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented Sep 12, 2024

BEGINRELEASENOTES

ENDRELEASENOTES

… of algobal union of intersections...

No overlaps detected and the finding points on surface does not complain any more
at least the lumical specific overlap check with /geometry/test/resolution 300000 is much faster now as well???
Copy link
Contributor

@Zehvogel Zehvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I wonder what the point of the intersections was? Were they necessary to be put into the union?

@andresailer
Copy link
Contributor Author

I wonder what the point of the intersections was? Were they necessary to be put into the union?

I was asking myself the same thing, of why using bool of bool instead of assembly.
Unions are supposed to be "well overlapping", so doing an union of just the tubes was giving an exception.

@atolosadelgado
Copy link
Contributor

I have run a quick simulation with geantinos, it seems to stay in the same place within 10 um tolerance, so it is ok for me :)

@Zehvogel
Copy link
Contributor

I have run a quick simulation with geantinos, it seems to stay in the same place within 10 um tolerance, so it is ok for me :)

It should not move at all :)
given the order of changes that we did in the past to the LumiCal, a tolerance of 10 microns seems a bit rough?

@atolosadelgado
Copy link
Contributor

I have run a quick simulation with geantinos, it seems to stay in the same place within 10 um tolerance, so it is ok for me :)

It should not move at all :) given the order of changes that we did in the past to the LumiCal, a tolerance of 10 microns seems a bit rough?

sorry, my mistake, I have checked again at actually stays in place!

@andresailer andresailer merged commit baa438a into key4hep:main Sep 12, 2024
5 of 6 checks passed
@andresailer andresailer deleted the fixLumiCalBackShield branch September 12, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geant4 complaints about LumiCalBackShield (CLD)
3 participants