Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurability for material plots #392
base: main
Are you sure you want to change the base?
Configurability for material plots #392
Changes from all commits
a440ac4
afa676d
f3c25cf
0a22949
f17ff2a
aa842a8
8092a73
bb7bdde
31815ef
73a81e5
25946e5
7104691
b58cdcb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This technically changes the default geometry from
IDEA_o1_v02.xml
to an ILD geometry. However, it also looks like the previous version didn't work without editing the file?Technically this should be a positional (required) argument, since the script can't do anything useful without it. However, at this point
--compactFile
is also pretty much a convention for several scripts.For me these changes are OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't care which detector is the default as long as the path is absolute or relative to
$K4GEO
or$k4geo_DIR
. Originally the path was relative and Daniel and I had trouble getting it to work. I think this should work out of the box without assuming a current working dirThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally which path was relative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path to the
IDEA_o1_v02.xml
compact file.edit: I.e. the script only work if called in the directory where that file was, IIUC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, ok, the detector file was just hard coded. I guess the compactFile will accept relative or absolute paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly. And yes, absolute and relative paths will work. It is directly passed to the
GeoSvc.detectors
.