Add the possibility to pass additional cmake arguments

[tmadlener]

BEGINRELEASENOTES

• Add the possibility to pass additional cmake arguments to the action

ENDRELEASENOTES

Would allow to simply pass the necessary arguments to download the STL files on the fly for key4hep/k4geo#428

[jmcarcell]

For using this I see two ways each with problems. Modifying the workflow that exists right now is not great because it would get overwritten when there are updates. Creating another workflow with the extra options means that workflow won't get updates automatically when they are applied to all the repositories.

[tmadlener]

Yeah, neither is ideal. Currently when the workflow is updated, the workflows/key4hep-build.yaml is simply copied to all the repositories, right? (btw: is there a script does that? If so, where does that live).

I am wondering how often we have to actually change the workflow file. It's mainly the images at this point, I would assume. The rest will be picked up via changes to the action(?). In principle it would be possible to write a tiny python script that e.g. just updates the images.

I think the action needs to be a bit more flexible as it is now, because otherwise we will have to start changing default build, cmake or test options in packages, simply because the action cannot deal with small differences properly.

[jmcarcell]

Yeah, neither is ideal. Currently when the workflow is updated, the workflows/key4hep-build.yaml is simply copied to all the repositories, right? (btw: is there a script does that? If so, where does that live).

Yes, it's this one https://github.com/key4hep/key4hep-dev-utils/blob/fcc-packages/scripts/sync-files.sh

I am wondering how often we have to actually change the workflow file. It's mainly the images at this point, I would assume. The rest will be picked up via changes to the action(?). In principle it would be possible to write a tiny python script that e.g. just updates the images.

It's updating images or sometimes updating the workflow for some reason. There are not so many changes but I think in the coming weeks there are going to be some changes, maybe the addition of workflows using the stack on LCGCmake so creating an additional workflow in k4geo may just be easier. At least for alma9 there are no updates.

I think the action needs to be a bit more flexible as it is now, because otherwise we will have to start changing default build, cmake or test options in packages, simply because the action cannot deal with small differences properly.

Yes probably, so far the set of tests that one should run locally and on CI have been the same. I don't have any problems with this.