Skip to content

Commit

Permalink
Update TODO with preliminary findings
Browse files Browse the repository at this point in the history
Signed-off-by: Evy Bongers <[email protected]>
  • Loading branch information
EvyBongers committed Mar 11, 2025
1 parent ea611d0 commit 22d8790
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ namespace plugin {
uint16_t ColormapOverlay::map_base_;

void ColormapOverlay::setup() {
// TODO: check if a call to ::LEDPaletteTheme.reserveThemes() is actually needed
// It appears that a call to ::LEDPaletteTheme.reserveThemes() is needed
// because it's where palette_base_ gets initialized. Since this plugin (and
// possibly others) don't actually use themes, requesting memory for storing
// themes doesn't make much sense. Maybe initialisation of palette_base_
// could be moved to a setup() method, though maybe the palette should be
// split from palette theme altogether?
map_base_ = ::LEDPaletteTheme.reserveThemes(1);
}

Expand Down

0 comments on commit 22d8790

Please sign in to comment.