Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus command for retreiving a list of installed LED effects #1387

Merged
merged 51 commits into from
Mar 13, 2024
Merged

Add focus command for retreiving a list of installed LED effects #1387

merged 51 commits into from
Mar 13, 2024

Commits on Feb 25, 2024

  1. Implement focus command for querying LED modes 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1a00ff1 View commit details
    Browse the repository at this point in the history

  2. First onLedEffectQuery implementation 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    e8e23d6 View commit details
    Browse the repository at this point in the history

  3. Initial implementation in all LED effect plugins 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f1a988b View commit details
    Browse the repository at this point in the history

  4. Implement onLedEffectQuery on both rainbow effects 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    6a2a608 View commit details
    Browse the repository at this point in the history

  5. Implement onLedEffectQuery in LEDOff as well 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    c137e4a View commit details
    Browse the repository at this point in the history

  6. Implement onLedEffectQuery in LEDModeInterface 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f0351c2 View commit details
    Browse the repository at this point in the history

  7. Implement new design in ActiveLayerKeys 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    ec7bf20 View commit details
    Browse the repository at this point in the history

  8. Implement new design in LEDOff 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1ad9749 View commit details
    Browse the repository at this point in the history

  9. Implement new design in FingerPainterEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    43fe544 View commit details
    Browse the repository at this point in the history

  10. Implement new design in HeatmapEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    ff729f3 View commit details
    Browse the repository at this point in the history

  11. Implement new design in Colormap 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    04fda4f View commit details
    Browse the repository at this point in the history

  12. Implement new design in LEDActiveLayerColor 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    690843d View commit details
    Browse the repository at this point in the history

  13. Implement new design in AlphaSquareEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f9f4d81 View commit details
    Browse the repository at this point in the history

  14. Implement new design in StalkerEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f45c4f4 View commit details
    Browse the repository at this point in the history

  15. Implement new design in WavepoolEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    af109f8 View commit details
    Browse the repository at this point in the history

  16. Implement new design in TriColorEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    312aacd View commit details
    Browse the repository at this point in the history

  17. Implement new design in LEDBreatheEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    22c6f64 View commit details
    Browse the repository at this point in the history

  18. Implement new design in LEDChaseEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    0f11dee View commit details
    Browse the repository at this point in the history

  19. Implement new design in rainbow effects 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    0e41496 View commit details
    Browse the repository at this point in the history

  20. Implement new design in SolidColorEffect 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    4cab81a View commit details
    Browse the repository at this point in the history

  21. Implement new design in DigitalRain 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    ca320fc View commit details
    Browse the repository at this point in the history

  22. Fix cpplint errors 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    ad6dae5 View commit details
    Browse the repository at this point in the history

  23. Fix code style errors 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    835290a View commit details
    Browse the repository at this point in the history

  24. At least get the color right 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    9aefde8 View commit details
    Browse the repository at this point in the history

  25. Allow user to set a custom name for led modes 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    cb761e0 View commit details
    Browse the repository at this point in the history

  26. Rename focus command to led_modes 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    5f00677 View commit details
    Browse the repository at this point in the history

  27. Drop lost onLedEffectQuery methods 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    a1e7d6a View commit details
    Browse the repository at this point in the history

  28. Clean up unused imports 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    b42ebb8 View commit details
    Browse the repository at this point in the history

  29. We like consistency 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    54a1428 View commit details
    Browse the repository at this point in the history

  30. Another update to led modes focus command :) 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    ee6904b View commit details
    Browse the repository at this point in the history

  31. Strip the Effect suffix of led mode names 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    4017c89 View commit details
    Browse the repository at this point in the history

  32. Mark single-parameter constructors as explicit 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    947453c View commit details
    Browse the repository at this point in the history

  33. Send a default string for unnamed led modes 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    297a4dd View commit details
    Browse the repository at this point in the history

  34. Remove FocusSerial dependency in LEDModeInterface 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    9e30b1e View commit details
    Browse the repository at this point in the history

  35. Make cpplint happy 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    853f6ca View commit details
    Browse the repository at this point in the history

  36. Send over focus differently 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    c4e7094 View commit details
    Browse the repository at this point in the history

  37. Use a callback to send led mode names over focus 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f235ce6 View commit details
    Browse the repository at this point in the history

  38. Consistent use of const char* 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    9b61e7f View commit details
    Browse the repository at this point in the history

  39. Fix led mode names for TriColor effects 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    bae2088 View commit details
    Browse the repository at this point in the history

  40. Strip "LED" prefix from led mode names 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    4122d6f View commit details
    Browse the repository at this point in the history

  41. Store led mode names in sketch storage 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    dd93a06 View commit details
    Browse the repository at this point in the history

  42. Fix oversight in Tricolor 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    b08125e View commit details
    Browse the repository at this point in the history

  43. Fix remaining constructors 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    77e3d69 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Rename callback method 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    aa905ae View commit details
    Browse the repository at this point in the history

  2. Rename member variables to according to style guide 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1807e14 View commit details
    Browse the repository at this point in the history

  3. Rename constructor arguments 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c6cf3a8 View commit details
    Browse the repository at this point in the history

  4. Code style 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b7e0ce7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'keyboardio:master' into feat/LedEffectNames

    @EvyBongers
    EvyBongers authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b59aef2 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Merge remote-tracking branch 'upstream/master' into feat/LedEffectNames

    @EvyBongers
    EvyBongers committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    41c6052 View commit details
    Browse the repository at this point in the history

  2. Stop using F() 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5c51f43 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Remove duplicate code 

    Signed-off-by: Evy Bongers <[email protected]>
    @EvyBongers
    EvyBongers committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    165b179 View commit details
    Browse the repository at this point in the history