hid::Keyboardio: Make it possible to switch the default protocol via Props #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the Model01's `setup()` method non-static, so that we can call the parents `setup()` method too. We want to do that so if new drivers are added, we automatically pick those up. Signed-off-by: Gergely Nagy <[email protected]>
To make it easier to configure which HID implementation - and which parts of it - a particular board uses, we turn our current HID facade (`kaleidoscope::hid`) into a proper, Props-supported driver. This also allows us to get rid of the `Kaleidoscope-HIDAdaptor-KeyboardioHID` library. Signed-off-by: Gergely Nagy <[email protected]>
Signed-off-by: Gergely Nagy <[email protected]>
…Props Signed-off-by: Gergely Nagy <[email protected]>
obra
reviewed
Dec 13, 2019
| static void reset_warping(); | ||
| static void pressButton(uint8_t button); |
There was a problem hiding this comment.
where did the pressButton and releaseButton methods go?
There was a problem hiding this comment.
They went into the HID driver. Since MouseKeys was the only user of it, I just changed the call-site to call the driver's appropriate method instead.
|
Closing this, because Dygma decided they'll stick with NKRO default, and keyboardio/KeyboardioHID#62 turned out to be problematic on the Raise (but worked on the Model01...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #771, and depends on keyboardio/KeyboardioHID#62 in addition to that. It simply makes the default keyboard report protocol settable on a per-device basis via Props - at least when using
hid::Keyboardioas the HID driver.I deliberately made this dependent on our HID driver, because a default protocol may or may not make sense with another driver (eg, over BLE, it doesn't).
Together with its dependencies, this fixes keyboardio/KeyboardioHID#59.