updates and improvements to TS typings #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: define return type for userInfo() call chore: add missing properties to the Token interface/type
evanshortiss
commented
May 24, 2021
| * req.kauth.grant.access_token?.content.name returns the user's name | ||
| */ | ||
| kauth: { | ||
| grant: KeycloakConnect.Grant |
There was a problem hiding this comment.
The grant refers to properties such as grant.access_token. Will these always be defined? Current typings show them as possibly undefined (using the ? operator) as seen here.
Is it safe to remove the ? operator from those?
|
No need to open a JIRA we are using github issues now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add types to safely access to the underlying
kauthobject and read token data.Edit: Let me know if I should open a JIRA.