Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:(roles): Importable role by rolename #1043

Merged
merged 1 commit into from
Dec 31, 2024
Merged

feat:(roles): Importable role by rolename #1043

merged 1 commit into from
Dec 31, 2024
+475 −24

Conversation

denniskniep
Copy link
Contributor

No description provided.

sschu
sschu approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@sschu sschu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denniskniep I am not sure about adding this dependency to a BSD-licensed library. Is this really necessary or can we work around this?

@sschu sschu self-requested a review December 31, 2024 09:09
@denniskniep
Copy link
Contributor Author

@sschu thanks for the review, but the dependency is not new. It is already used by resource_keycloak_openid_client.go for the same purpose: Handle import: true (see here)

sschu
sschu approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@sschu sschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Ok, then I guess this is fine.

@sschu sschu merged commit de36bd6 into keycloak:main Dec 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sschu sschu sschu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniskniep @sschu