Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority field support in authentication flow executions #970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gim-
Copy link

@gim- gim- commented Jun 1, 2024

Allows to declaratively define authentication flow execution and subflow priority in Keycloak 25 onwards.

Additionally I've removed raisePriority/lowerPriority functions as they don't seem to be used anywhere.

Fixes #296

@gim- gim- force-pushed the auth-flow-executor-priority branch 3 times, most recently from 9d4f775 to 0019a54 Compare June 1, 2024 12:07
@gim-
Copy link
Author

gim- commented Jun 1, 2024

Test run in GitHub actions appears to be flaky.

@gim- gim- marked this pull request as ready for review June 20, 2024 05:00
@berni2288
Copy link

Hey, is there anything that blocks this PR from being merged?
If I understood it right, the Github action test is just buggy.

@gim-
Copy link
Author

gim- commented Jul 8, 2024

@berni2288 The project is not maintained unfortunately - #964

@ToniA
Copy link

ToniA commented Nov 12, 2024

@gim- Any chance you could publish your build into Terraform registry?

Just banging my head against the wall with this priority mess...

@oysteinhauan
Copy link
Contributor

oysteinhauan commented Nov 18, 2024

Thanks, we need this desperately. As a temporary solution we have done the following:

  1. Fork terraform-provider-keycloak repo and fetch this branch from @gim- 's fork.
  2. Run make build, or go build -o terraform-provider-keycloak_v5.0.0-priority
  3. Place the executable in your plugin-path, e.g. /Users/username/.terraform.d/plugins/registry.terraform.io/mrparkers/keycloak/5.0.0-priority/
  4. Create a .terraformrc file with the following content:
provider_installation {
    filesystem_mirror {
        path = "/Users/username/.terraform.d/plugins"
        include = ["registry.terraform.io/mrparkers/keycloak"]
    }
    direct {
        exclude = ["registry.terraform.io/mrparkers/keycloak"]
    }
}

This tells terraform to not fetch mrparkers/keycloak from the registry, but from your local path.

  1. Set the provider version in terraform to 5.0.0-priority (or whatever version name you have chosen)
  2. Run terraform init -upgrade.

Hope this can help!

@gim- gim- force-pushed the auth-flow-executor-priority branch 7 times, most recently from 932465b to 68bead4 Compare December 25, 2024 10:44
@missedone
Copy link

@sschu could you take a look at this PR, which solved the really annoying issue when updating the auth flow in KC 25+

@sschu
Copy link
Contributor

sschu commented Dec 31, 2024

@gim- @missedone Please see my comment here: #1040 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for defining Flow priorities declaratively
6 participants