Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes to make helm build more resilient #60

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

galmasi
Copy link

@galmasi galmasi commented Jan 25, 2024

The following small fixes were required to build the helm chart successfully on an Ubuntu 22.04 machine with helm 3.11.3:

  • The main chart referring to the controller has to have a version number (added "0.1.0")
  • The metrics service had to have its name shortened to fit into the required 64 character limit.

With the fixes, the helm chart builds and deploys correctly (not tested with the controller, that's subject for a next PR)

Test protocol for reproducing the problems this PR claims to fix:

  • Ubuntu 22.04 host, helm v3.11.3
  • Checkout the current main branch of attestation operator
  • make helm-clean followed by make helm to ensure a clean environment
  • make helm-keylime-deploy to test the built chart
  • values.yaml is mostly indifferent, corresponds to the first default in the README

George Almasi added 2 commits January 25, 2024 14:21
… dependency in the main keylime chart.

Signed-off-by: George Almasi <[email protected]>
@galmasi
Copy link
Author

galmasi commented Jan 25, 2024

I just noticed that this PR duplicates the functionality of #57 . Under the circumstances let's merge 57 first, and I'll rebase this.

@maugustosilva maugustosilva merged commit 55a76ae into keylime:main Jan 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants