Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove exception handler for Keyman Desktop 10 #250

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

mcdurdin
Copy link
Member

We no longer do anything with crash reports from early versions of Keyman, so there's no point in collecting the data. This also resolves a crash when handling some reports.

This also removes the need to have the api_keyman_com_github_user and api_keyman_com_github_repo variables defined, which will be cleaned up as a future task.

Fixes: #249
Fixes: API-KEYMAN-COM-4H

We no longer do anything with crash reports from early versions of
Keyman, so there's no point in collecting the data. This also resolves
a crash when handling some reports.

This also removes the need to have the api_keyman_com_github_user and
api_keyman_com_github_repo variables defined, which will be cleaned up
as a future task.

Fixes: #249
Fixes: API-KEYMAN-COM-4H
@mcdurdin mcdurdin added this to the A18S3 milestone May 29, 2024
@mcdurdin mcdurdin added the chore label May 29, 2024
@mcdurdin mcdurdin merged commit 7a4211c into master Jun 5, 2024
2 checks passed
@mcdurdin mcdurdin deleted the chore/249-remove-keyman-10-exception-handler branch June 5, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants