Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select first matching language name where there are conflicts, and fix null language description #254

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Jun 3, 2024

Fixes two bugs:

  • null language description when importing from a valid .keyboard_info caused an SQL error
  • if two keyboard_info files had the different language name for the same tag, it could cause an SQL error.

Also splits search-prepare-data.sql to make it easier to debug.

Relates to keymanapp/keyboards#2423

Fixes: #253

@mcdurdin mcdurdin added this to the A18S3 milestone Jun 3, 2024
@mcdurdin mcdurdin added the fix label Jun 3, 2024
@mcdurdin
Copy link
Member Author

mcdurdin commented Jun 3, 2024

I manually verified that the sequence of search-prepare-data-*.sql files were identical in function to search-prepare-data.sql (before -6 was patched in the second commit):

cat search-prepare-data-*.sql > spd.sql
diff search-prepare-data.sql spd.sql

null,
'001', --t.region,
'World', --t.regionname,
(select top 1 kl0.description from k0.t_keyboard_language kl0 where kl0.bcp47 = kl.bcp47),
Copy link
Member Author

@mcdurdin mcdurdin Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change in the search-prepare-data*.sql series; was:

  kl.description,

@mcdurdin mcdurdin merged commit 10d532d into master Jun 3, 2024
2 checks passed
@mcdurdin mcdurdin deleted the fix/253-data-fixups-for-staging-17 branch June 3, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: api deployment fails with staging-17.0 data - NULL language name from t_langtags?
2 participants