Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing comma in tengwar.keyboard_info #3339

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mcdurdin
Copy link
Member

The patch in #3336 missed a comma, which broke the release build. (The files in legacy/ are more fragile and do not have many build checks, as they generally do not get modified.)

Fixes: #3333
Emerging-From: #3336

The patch in #3336 missed a comma, which broke the release build. (The
files in legacy/ are more fragile and do not have many build checks, as
they generally do not get modified.)

Fixes: #3333
Emerging-From: #3336
Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry! It's been awhile since I edited a keyboard_info file. LGTM.

@mcdurdin
Copy link
Member Author

So sorry! It's been awhile since I edited a keyboard_info file.

All good, a nice reminder of how much better life is now that we no longer require manual editing of .keyboard_info for experimental/release!

@mcdurdin mcdurdin enabled auto-merge February 12, 2025 01:58
@mcdurdin mcdurdin merged commit 51fe196 into master Feb 12, 2025
2 checks passed
@mcdurdin mcdurdin deleted the chore/tengwar-keyboard-info branch February 12, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(tengwar): two keyboards with the same name
2 participants