Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(web): warning during multitap handling on modifier keys with longpresses #12963

Closed
sentry-io bot opened this issue Jan 21, 2025 · 3 comments · Fixed by #12964
Closed

bug(web): warning during multitap handling on modifier keys with longpresses #12963

sentry-io bot opened this issue Jan 21, 2025 · 3 comments · Fixed by #12964
Assignees
@jahorton
Labels
bug web/
Milestone
A18S20

Comments

@sentry-io
Copy link

sentry-io bot commented Jan 21, 2025

Sentry Issue: KEYMAN-WEB-G9

Error:  Could not find current layer's key
  at reduceConsoleArgs (/data/user/0/com.tavultesoft.kmapro/app_data/keyman-sentry.js:150:22)
  at console.reportingConsoleWarn [as warn] (/data/user/0/com.tavultesoft.kmapro/app_data/keyman-sentry.js:143:33)
  at stageHandler (@keymanapp/keyman/web/src/engine/osk/src/input/gestures/browser/multitap.ts:115:19)
  at Dr.<anonymous> (@keymanapp/keyman/common/web/gesture-recognizer/src/engine/headless/gestures/matchers/gestureSequence.ts:262:10)
  at Generator.next (<anonymous>)
...
(8 additional frame(s) were not displayed)
@jahorton
Copy link
Contributor

This is most prominently seen with the naijatype keyboard, which has a subkey for caps layer on the default-layer shift key. The console warning triggering this event will reliably reproduce whenever double-tapping said shift key.

As we filter out modifier keys and frame keys when considering fat-finger targets, the engine doesn't find a key matching shift or caps in the standard fat-finger distributions. We have filtering in place when modipress is enabled... but not when it isn't. A key with supported longpresses automatically has modipress disabled... leading to the issue.

@jahorton jahorton mentioned this issue Jan 21, 2025
Merged
@jahorton
Copy link
Contributor

This was also seen for one user with a brythonic keyboard, but that is not currently published in our keyboards repository.

@github-project-automation github-project-automation bot moved this to Done in Keyman Jan 22, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S20 milestone Jan 22, 2025
jahorton pushed a commit that referenced this issue Jan 22, 2025
fix(web): prevents multitap warning that occurs multitapping longpres…
818e75c 
…sable modifier keys

Fixes: #12963
Cherry-pick-of: #12964
@jahorton jahorton mentioned this issue Jan 22, 2025
Merged
@jahorton
Copy link
Contributor

Well, we've got a few pings after that PR merged... but they're all from a keyboard we don't distribute: ip13_final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jahorton jahorton

Labels
bug web/
Projects
Keyman
Archived in project
Milestone
A18S20
Development

Successfully merging a pull request may close this issue.

fix(web): prevent warning that occurs when multitapping longpressable modifier keys keymanapp/keyman
1 participant
@jahorton