Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): prevent multitap warning that occurs multitapping longpressable modifier keys 🏠 #12974

Merged

Conversation

jahorton
Copy link
Contributor

Fixes: #12963
Cherry-pick-of: #12964

User Testing

TEST_NAIJATYPE_CAPS_ON_ANDROID: Using Keyman for Android..

  1. Double-tap on the default-layer shift key and verify that:
    • No error or warning messages appear
    • The CAPS layer activates and holds, even after typing a couple of letters
  2. Triple-tap the default layer i key, verifying that results and that no errors or warnings occur.

TEST_EUROLATIN: Using Keyman for Android, verify that the keyboard's caps-lock behavior works properly.

Unverified

No user is associated with the committer email.
…sable modifier keys

Fixes: #12963
Cherry-pick-of: #12964
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 22, 2025
@github-actions github-actions bot added the web/ label Jan 22, 2025
@github-actions github-actions bot added the fix label Jan 22, 2025
@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(web): prevents multitap warning that occurs multitapping longpressable modifier keys fix(web): prevents multitap warning that occurs multitapping longpressable modifier keys 🏠 Jan 22, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S20 milestone Jan 22, 2025
@mcdurdin mcdurdin changed the title fix(web): prevents multitap warning that occurs multitapping longpressable modifier keys 🏠 fix(web): prevent multitap warning that occurs multitapping longpressable modifier keys 🏠 Jan 22, 2025
@jahorton
Copy link
Contributor Author

Keyman - iOS build error:

10:06:43   error: exportArchive: No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found
10:06:43   
10:06:43   Error Domain=IDECodesignResolverErrorDomain Code=1 "No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found" UserInfo={IDEDistributionIssueSeverity=3, NSLocalizedRecoverySuggestion=Specify a different signing certificate for "signingCertificate" in your Export Options property list., IDEProvisioningError_UserInfoKey_IDEProvisioningErrorSpecifier=BB842A0081298BBA6D034C85451750B08FC9EE8A, NSLocalizedDescription=No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorPlatform=com.apple.platform.iphoneos, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorAction=5, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorTeam=<IDEProvisioningBasicTeam: 0x600001340120; teamID='3YE4W86L3G', teamName='(null)'>}
10:06:43   
10:06:43   error: exportArchive: No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found
10:06:43   
10:06:43   Error Domain=IDECodesignResolverErrorDomain Code=1 "No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found" UserInfo={IDEDistributionIssueSeverity=3, NSLocalizedRecoverySuggestion=Specify a different signing certificate for "signingCertificate" in your Export Options property list., IDEProvisioningError_UserInfoKey_IDEProvisioningErrorSpecifier=BB842A0081298BBA6D034C85451750B08FC9EE8A, NSLocalizedDescription=No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorPlatform=com.apple.platform.iphoneos, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorAction=5, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorTeam=<IDEProvisioningBasicTeam: 0x600001340120; teamID='3YE4W86L3G', teamName='(null)'>}

@jahorton
Copy link
Contributor Author

Keyman Core - WASM build failure:

[developer/src/kmcmplib] locate_emscripten: Variable EMSCRIPTEN_BASE (/home/bob/emsdk/upstream/emscripten) contains emcc.py but it is not executable

@mcdurdin
Copy link
Member

Keyman - iOS build error:

10:06:43   error: exportArchive: No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found
10:06:43   
10:06:43   Error Domain=IDECodesignResolverErrorDomain Code=1 "No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found" UserInfo={IDEDistributionIssueSeverity=3, NSLocalizedRecoverySuggestion=Specify a different signing certificate for "signingCertificate" in your Export Options property list., IDEProvisioningError_UserInfoKey_IDEProvisioningErrorSpecifier=BB842A0081298BBA6D034C85451750B08FC9EE8A, NSLocalizedDescription=No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorPlatform=com.apple.platform.iphoneos, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorAction=5, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorTeam=<IDEProvisioningBasicTeam: 0x600001340120; teamID='3YE4W86L3G', teamName='(null)'>}
10:06:43   
10:06:43   error: exportArchive: No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found
10:06:43   
10:06:43   Error Domain=IDECodesignResolverErrorDomain Code=1 "No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found" UserInfo={IDEDistributionIssueSeverity=3, NSLocalizedRecoverySuggestion=Specify a different signing certificate for "signingCertificate" in your Export Options property list., IDEProvisioningError_UserInfoKey_IDEProvisioningErrorSpecifier=BB842A0081298BBA6D034C85451750B08FC9EE8A, NSLocalizedDescription=No certificate for team '3YE4W86L3G' matching 'BB842A0081298BBA6D034C85451750B08FC9EE8A' found, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorPlatform=com.apple.platform.iphoneos, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorAction=5, IDEProvisioningError_UserInfoKey_IDEProvisioningErrorTeam=<IDEProvisioningBasicTeam: 0x600001340120; teamID='3YE4W86L3G', teamName='(null)'>}

Keyman Core - WASM build failure:

[developer/src/kmcmplib] locate_emscripten: Variable EMSCRIPTEN_BASE (/home/bob/emsdk/upstream/emscripten) contains emcc.py but it is not executable

Your branch is out of date.

@jahorton
Copy link
Contributor Author

Huh, I'd have sworn I updated it / git pull'd before this. Oh well, will try again.

…-multitap-warning
@dinakaranr
Copy link

Test Results

I tested this issue with the attached "Keyman-17.0.334-alpha-test-12974" build(24/01/2025) on Android 14(Physical Device) and Android 13(Emulator). I'm sharing my observation here.

  • TEST_NAIJATYPE_CAPS_ON_ANDROID (Passed):
  1. Installed the "Keyman-17.0.334.apk" file from this PR build.
  2. Open the Keyman app.
  3. Checked the "Enable Keyman as system-wide keyboard". Set the keyboard as the default keyboard box on the settings page.
  4. Installed the "NAIJATYPE" keyboard.
  5. Navigate to the Keyman edit notepad.
  6. Enter some letters using the "naijatype" keyboard.
  7. Double tap on the "Shift" key.
  8. Verified that no error & warning message appeared.
  9. Hold on to any cap key and then select the subkeys.
  10. Verified that the subkeys appeared
  11. Disable the caps layer by pressing the "Shift key"
  12. Triple-tap the default layer " i " key.
  13. Verified that no error & warning message appeared.
  14. Verified that the " ị " letter appeared.
    It works well.
  • TEST_EUROLATIN (Passed):
  1. Installed the "Keyman-17.0.334.apk" file from this PR build.
  2. Open the Keyman app.
  3. Checked the "Enable Keyman as system-wide keyboard". Set the keyboard as the default keyboard box on the settings page.
  4. Double tap on the "Shift" key.
  5. Verified that no error & warning message appeared.
  6. Hold on to any cap key and then select the subkeys.
  7. Verified that the subkeys appeared.
    It works well.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 24, 2025
@jahorton jahorton merged commit ac90d3d into stable-17.0 Jan 27, 2025
15 checks passed
@jahorton jahorton deleted the fix/web/cherrypick-longpress-modifier-multitap-warning branch January 27, 2025 01:14
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants