fix(web): correctly track context transitions caused by applying suggestions 🖲️ #12927
+101
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
force-pushed
the
fix/web/context-match-applied-suggestions
branch
from
d8500ee to
5633b9c
Compare
jahorton
changed the title
…xt-match-applied-suggestions
mcdurdin
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to properly present a reversion option after multiple edits to context, it's wise to ensure we properly track context changes caused by applying suggestions. After all, if we can't do that, it'll be hard to compare the 'before' and 'after' states in order to handle things properly.
This also adds two new unit tests targeting the specific scenario being addressed. Minor maintenance was needed to maintain the recently-added unit test from #12864, as the scenario shares much of the same control flow and logic as the newly-handled case.
@keymanapp-test-bot skip