fix(platform): Platform types fixes #374

DhairyaMajmudar · 2024-07-27T06:21:41Z

User description

Description

platform types fixes

Fixes #371

Dependencies

Update the typescript version to 5.3.3
Adding @types/dayjs-precise-range in platform package.json

Future Improvements

N/A

Mentions

@rajdip-b

Screenshots of relevant screens

Developer's checklist

My PR follows the style guidelines of this project
I have performed a self-check on my work

If changes are made in the code:

I have followed the coding guidelines
My changes in code generate no new warnings
My changes are breaking another fix/feature of the project
I have added test cases to show that my feature works
I have added relevant screenshots in my PR
There are no UI/UX issues

Documentation Update

This PR requires an update to the documentation at docs.keyshade.xyz
I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

enhancement, dependencies

Description

Added @types/dayjs-precise-range to devDependencies in apps/platform/package.json.
Updated typescript version from ^4.5.3 to ^5.3.3 in apps/platform/package.json.

Changes walkthrough 📝

Relevant files

Dependencies

package.json `Update TypeScript version and add new type definitions` apps/platform/package.json Added `@types/dayjs-precise-range` to `devDependencies`. Updated `typescript` version from `^4.5.3` to `^5.3.3`.	+2/-1

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

codiumai-pr-agent-free · 2024-07-27T06:21:56Z

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

codiumai-pr-agent-free · 2024-07-27T06:22:11Z

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Pin the version of `@types/dayjs-precise-range` to a specific release Consider pinning the version of `@types/dayjs-precise-range` to avoid potential breaking changes that could occur with minor version updates. Using a specific version helps ensure consistent behavior across environments and deployments. apps/platform/package.json [54] -"@types/dayjs-precise-range": "^1.0.5", +"@types/dayjs-precise-range": "1.0.5", Apply this suggestion Suggestion importance[1-10]: 9 Why: Pinning the version of `@types/dayjs-precise-range` helps ensure consistent behavior across different environments and deployments, reducing the risk of unexpected issues due to minor version updates.	9
Maintainability	Pin the `typescript` version to a specific minor release Update the `typescript` version to a specific minor release instead of using the caret (^) version range. This can help in avoiding unexpected issues due to new minor versions which might introduce breaking changes. apps/platform/package.json [63] -"typescript": "^5.3.3" +"typescript": "5.3.3" Apply this suggestion Suggestion importance[1-10]: 9 Why: Pinning the `typescript` version to a specific minor release helps avoid unexpected issues that might arise from new minor versions introducing breaking changes, thus improving maintainability.	9

DhairyaMajmudar · 2024-07-27T06:28:31Z

Shall I also puch the changes done in pnpm-lock file ?

rajdip-b · 2024-07-27T06:29:32Z

Yes! We would need the lockfile changes.

…yshade into lint-platform

rajdip-b · 2024-07-27T06:36:20Z

@DhairyaMajmudar there's something that I would be glad if you can do. I see that these errors were related to typescript. Now that I see, all the different packages are using their own version of typescript. We don't want that. Could you please move out typescript to the root package.json dev dependency? And delete typescript from all the other package.json files?

DhairyaMajmudar · 2024-07-27T06:37:55Z

@DhairyaMajmudar there's something that I would be glad if you can do. I see that these errors were related to typescript. Now that I see, all the different packages are using their own version of typescript. We don't want that. Could you please move out typescript to the root package.json dev dependency? And delete typescript from all the other package.json files?

sounds correct, let's do this 🚀

apps/api/src/variable/controller/variable.controller.ts

apps/platform/package.json

DhairyaMajmudar · 2024-07-27T06:58:11Z

First time in life changing 5 package.json files at same time 💀

rajdip-b · 2024-07-27T06:58:27Z

xD

## [2.3.0](v2.2.0...v2.3.0) (2024-07-29) ### 🚀 Features * **api:** Add pagination metadata to Environment module ([#382](#382)) ([9baa344](9baa344)) * **api:** Add pagination metadata to Event module ([#394](#394)) ([60010b4](60010b4)) * **api:** Add pagination metadata to Integration module ([#391](#391)) ([0372e36](0372e36)) * **api:** Add pagination metadata to Project module ([#393](#393)) ([bc274fd](bc274fd)) * **api:** Add pagination metadata to Secret module ([#389](#389)) ([c4cc667](c4cc667)) * **api:** Add pagination metadata to Variable module ([#390](#390)) ([be6aabf](be6aabf)) * **api:** Add pagination metadata to Workspace module ([#387](#387)) ([a08c924](a08c924)) * **api:** Add pagination metadata to Workspace Role module ([#388](#388)) ([d8e8f49](d8e8f49)) * **api:** Create a paginate method ([#379](#379)) ([09576f1](09576f1)) * **api:** Create endpoint for fetching all revisions of a [secure] ([#303](#303)) ([de2b602](de2b602)) * **api:** Create endpoint for fetching all revisions of a variable ([#304](#304)) ([9abddc1](9abddc1)) * **cli:** Improved the DX for list profile ([#334](#334)) ([6bff496](6bff496)) * **platform:** Add warning sonner toast for invalid otp ([#335](#335)) ([21513f5](21513f5)) ### 🐛 Bug Fixes * **cli:** Added parent directory check ([#359](#359)) ([538ea7f](538ea7f)) * **platform:** Platform types fixes ([#374](#374)) ([8e9d9ff](8e9d9ff)) ### 📚 Documentation * Added docker details in setting-things-up.md ([#358](#358)) ([ed5093a](ed5093a)) * Update postman workspace link ([d6aba27](d6aba27)) * Updated env and cli docs ([1213d2a](1213d2a)) ### 🔧 Miscellaneous Chores * Added next backend url in .env.example ([5695254](5695254)) * **api-client:** Added pagination structure ([a70e957](a70e957)) * **api-client:** Fixed test script ([ad70819](ad70819)) * **api-client:** Removed try-catch from tests in environment ([a64e48c](a64e48c)) * **api:** Add user cache for optimization ([#386](#386)) ([8d730b5](8d730b5)) * **api:** Alter cache rehydration interval ([f5f9eec](f5f9eec)) * **api:** Fixed naming error in variable controller ([0c5a380](0c5a380)) * **api:** Improve handling of edge cases for paginate module ([#402](#402)) ([8591487](8591487)) * **api:** Minor updates to user service ([249d778](249d778)) * **api:** Skip workspace creation when user is admin ([#376](#376)) ([13f6c59](13f6c59)) * **ci:** Add docker check ([#383](#383)) ([3119001](3119001)) * **ci:** Add names to CI files ([1a7e5f6](1a7e5f6)) * **ci:** Add validate CLI pipeline ([#373](#373)) ([a91df6c](a91df6c)) * **ci:** Adding validate pipeline ([#372](#372)) ([23cf3b3](23cf3b3)) * **ci:** Disabled platform and api deployments ([74d601a](74d601a)) * **ci:** Fixed deployment scripts ([12e35db](12e35db)) * **ci:** Fixed platform script ([d783f2a](d783f2a)) * **CI:** Include migration deployment in API deploy pipeline ([dbd5222](dbd5222)) * **CI:** Separated deployment and docker build jobs ([090e193](090e193)) * **CI:** Setup inter-job dependency ([1756727](1756727)) * **ci:** Update auto-assign.yaml ([#375](#375)) ([91e0ec1](91e0ec1)) * **cli:** Changed objects to classes ([#306](#306)) ([c83f2db](c83f2db)) * Removed Minio config ([8feb83a](8feb83a)) * Updated deployment scripts and added health check in platform ([fcc1c3f](fcc1c3f)) ### 🔨 Code Refactoring * **api:** Updated path of some endpoints in project controller ([9502678](9502678)) * **api:** Updated Redis provider ([33491a1](33491a1))

fix: platform types fixes

1c076f4

DhairyaMajmudar requested a review from kriptonian1 as a code owner July 27, 2024 06:21

codiumai-pr-agent-free bot added enhancement Dependencies Review effort [1-5]: 1 labels Jul 27, 2024

DhairyaMajmudar added 2 commits July 27, 2024 11:52

Merge branch 'develop' into lint-platform

fffadae

Merge branch 'develop' into lint-platform

bc55f6f

rajdip-b changed the title ~~fix: platform types fixes~~ fix(platform): Platform types fixes Jul 27, 2024

DhairyaMajmudar added 4 commits July 27, 2024 12:01

adding lockfile changes

86280bb

Merge branch 'lint-platform' of https://github.com/DhairyaMajmudar/ke…

4c165ad

…yshade into lint-platform

fix: platform types fixes

51768f5

adding lockfile changes

9a25887

rajdip-b force-pushed the lint-platform branch from 4c165ad to 9a25887 Compare July 27, 2024 06:34

rajdip-b approved these changes Jul 27, 2024

View reviewed changes

DhairyaMajmudar added 2 commits July 27, 2024 12:19

consolidating Typescript

3014dee

consolidating Typescript

a4b55de

rajdip-b requested changes Jul 27, 2024

View reviewed changes

apps/api/src/variable/controller/variable.controller.ts Outdated Show resolved Hide resolved

apps/platform/package.json Show resolved Hide resolved

minor fixes

28c7576

rajdip-b approved these changes Jul 27, 2024

View reviewed changes

minor fixes

fa1954e

rajdip-b approved these changes Jul 27, 2024

View reviewed changes

rajdip-b merged commit 116aa88 into keyshade-xyz:develop Jul 27, 2024
7 checks passed

DhairyaMajmudar deleted the lint-platform branch July 27, 2024 06:59

rajdip-b pushed a commit that referenced this pull request Jul 29, 2024

fix(platform): Platform types fixes (#374)

8e9d9ff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(platform): Platform types fixes #374

fix(platform): Platform types fixes #374

DhairyaMajmudar commented Jul 27, 2024 •

edited by codiumai-pr-agent-free bot

Loading

codiumai-pr-agent-free bot commented Jul 27, 2024

codiumai-pr-agent-free bot commented Jul 27, 2024

DhairyaMajmudar commented Jul 27, 2024

rajdip-b commented Jul 27, 2024

rajdip-b commented Jul 27, 2024

DhairyaMajmudar commented Jul 27, 2024

DhairyaMajmudar commented Jul 27, 2024

rajdip-b commented Jul 27, 2024

fix(platform): Platform types fixes #374

fix(platform): Platform types fixes #374

Conversation

DhairyaMajmudar commented Jul 27, 2024 • edited by codiumai-pr-agent-free bot Loading

User description

Description

Dependencies

Future Improvements

Mentions

Screenshots of relevant screens

Developer's checklist

Documentation Update

PR Type

Description

Changes walkthrough 📝

codiumai-pr-agent-free bot commented Jul 27, 2024

PR Reviewer Guide 🔍

codiumai-pr-agent-free bot commented Jul 27, 2024

PR Code Suggestions ✨

DhairyaMajmudar commented Jul 27, 2024

rajdip-b commented Jul 27, 2024

rajdip-b commented Jul 27, 2024

DhairyaMajmudar commented Jul 27, 2024

DhairyaMajmudar commented Jul 27, 2024

rajdip-b commented Jul 27, 2024

DhairyaMajmudar commented Jul 27, 2024 •

edited by codiumai-pr-agent-free bot

Loading