-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add email template for inviting user to workspace #480
feat: Add email template for inviting user to workspace #480
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Hey man, that's some impressive work. Although again, the scope of this issue is outdated. So it would be Workspace, not project. And gladly, we already have a function for workspace. All you would need is to update the stylings of that mail template. Additionally, I would like to take a call from @kriptonian1 @darksaiii about the design decisions. |
@Allan2000-Git I like the work, but can you do the implementation in React email, they have better support for all email client and also have accessibility for clients which doesn't support HTML. |
@rajdip-b Will rename project to workspace. |
@rajdip-b should we make a new issue for this |
A new PR would be really great. I don't think we need a new issue for that, adding hacktoberfest-accepted to the PR should be enough. |
Yes, as per as I know, they just count the PR with |
90b8aed
to
92ff06e
Compare
@Allan2000-Git if you can implement these changes, I will be happy to merge. |
@rajdip-b Since the template has to be designed using |
@kriptonian1 can you please help him out? |
React email has preview, I'll recommend you to go through the docs and watch some tutorials on YouTube before diving into it. Here is a video you can refer to |
@Allan2000-Git hey buddy, any updates on this? |
Template is ready and is working fine |
Can you pull the changes from this PR and check. Would be of great help |
…nto feat/user-invitation-email-template
…com/Allan2000-Git/keyshade into feat/user-invitation-email-template
User description
Description
This PR adds an email template for inviting user to project. It provides users with key information regarding the project name
project joining URL, invited by, invited on and invitation role.
Fixes #54
Dependencies
No new dependencies introduced.
Future Improvements
N/A
Mentions
@rajdip-b
Screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
enhancement
Description
userInvitation
method to theIMailService
interface, allowing for user invitations via email.userInvitation
method inMailService
, which sends an HTML formatted email containing project invitation details and a call-to-action button.userInvitation
method inMockMailService
for testing, which logs the invitation details.Changes walkthrough 📝
interface.service.ts
Add user invitation method to mail service interface
apps/api/src/mail/services/interface.service.ts
userInvitation
method to theIMailService
interface.role.
mail.service.ts
Implement user invitation email with HTML template
apps/api/src/mail/services/mail.service.ts
userInvitation
method inMailService
.mock.service.ts
Add mock user invitation method for testing
apps/api/src/mail/services/mock.service.ts
userInvitation
method.