Support building on modern MSYS2 #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows for inet_ntop with corrent library, guard includes and definitions with configure results, cleanup header inclusion
* Explicitly include headers in config and tests * Update ChangeLog
Define argument to `_Block_release` and `_Block_get_types` to be `const void*`, to aligne with the header declaration.
NSObject uses objc_msg_lookup, which is defined in message.h
NSProxy uses objc_msg_lookup, which is defined in <objc/message.h>
This reverts commit 7658507.
'make check' tells me that I must use GNU make. The message now tells me to use gmake (or whatever make I used that worked for the build).
Remove -rpath flag when running tests with MSVC toolchain to fix build errors for tests as there is no rpath on Windows, and instead add object directory to PATH for Windows to find DLLs.
Having the same ivar exposed as different types in different compilation units is probably a bad idea in general and will break with the new ObjC ABI, where we have link-time checks for this. It would also confuse reflection and any languages that use reflection for bridging in exciting ways.
This is largely the version from the newabi branch, but with a few cleanups made possible by other bug fixes in the GSString implementations.
…ime.h> Most Linux distributions and MSYS2 include a version of BlocksRuntime which includes the `Block.h` header.
|
Best reviewed on a per-commit basis; most of the delta comes from a2aeb64 which could be split off into a separate PR if that's easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: