-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New test case for issue 101 #115
base: main
Are you sure you want to change the base?
Conversation
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@base <http://example.com/rules/> . | ||
|
||
<#CSVWSourceAccess> a rml:Source, csvw:Table; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to become rml:FilePath
instead of CSVW because CSVW is RML-IO-REGISTRY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this test case needs to be probably in RML-IO-REGISTRY because here we only have 'simple' CSV without any possible configuration. Is quoting with "
default for CSV? If yes, we can keep it here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a question for RML right? I am not sure what is the intended behaviour for an RML source that contains quotes. Should they be referenced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it depends on what the CSV spec says... We use the default behavior in RML-IO while allowing more config options in RML-IO-REGISTRY.
According to the RFC 4180 spec, double quotes is the standard, so the test case can stay here for RML-IO but should also go to RML-IO-REGISTRY where you change the double quotes to single quotes with CSVW. So 1 test case, 2 stones ;)
Fixes #101