Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup envoy admin port constants #10314

Open
bleggett opened this issue Nov 11, 2024 · 0 comments
Open

Fixup envoy admin port constants #10314

bleggett opened this issue Nov 11, 2024 · 0 comments

Comments

@bleggett
Copy link
Contributor

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.

Spun out of solo-io#10239

That PR removed envoyutil.admincli.DefaultAdminPort in favor of defaults.EnvoyAdminPort - they are the same value and having 2x constants in the codebase is confusing - most tests were using the latter already.

That being said

  1. We should try and move the constants closer to where they're used, if we can (should be done in one PR).
  2. I believe gloo admin port has the same problem, and should also be fixed.

Describe the solution you'd like

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants