You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That PR removed envoyutil.admincli.DefaultAdminPort in favor of defaults.EnvoyAdminPort - they are the same value and having 2x constants in the codebase is confusing - most tests were using the latter already.
That being said
We should try and move the constants closer to where they're used, if we can (should be done in one PR).
I believe gloo admin port has the same problem, and should also be fixed.
Describe the solution you'd like
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered:
Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.
Spun out of solo-io#10239
That PR removed
envoyutil.admincli.DefaultAdminPort
in favor ofdefaults.EnvoyAdminPort
- they are the same value and having 2x constants in the codebase is confusing - most tests were using the latter already.That being said
gloo admin port
has the same problem, and should also be fixed.Describe the solution you'd like
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: