-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glooctl snapshot cmd #10239
Add glooctl snapshot cmd #10239
Conversation
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Visit the preview URL for this PR (updated for commit b24e26c): https://gloo-edge--pr10239-bleggett-add-glooctl-1khsg578.web.app (expires Mon, 18 Nov 2024 20:09:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I think this tool will help the usage of capturing actionable information about the running cluster.
I shared some context about potential areas of the code that may solve parts of this already, or areas where we could expand our functionality for better re-use.
I know this is just a draft, but I was hoping to share this to help save you some time in case you were unaware of those code areas. Happy to chat further if it helps!
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Issues linked to changelog: |
Signed-off-by: Benjamin Leggett <[email protected]>
fcb87e5
to
43b5eea
Compare
This unit test failure looks spurious, it's not related to any change here. |
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
/kick-ci |
/test |
/kick-ci |
Description
Adds a
glooctl proxy snapshot
cmd, which will dump everything the gateway has (stats, config, listeners, endpoints) into a timestamped zipfile, to aid diagnosis of gateway (or non-gateway) problems.Some of these already exist piecemeal in the tool (config dump, stats dump) but this adds a few extra bobs and creates an artifact.
API changes
Code changes
glooctl proxy snapshot
GetEnvoyAdminData
to take any k8s specifier - previously it always assumed (but did not say) you should give it the name of a deployment. Now, it will work with either a kube-styledeployment/<name>
specifier, or a raw podname. This was added forglooctl proxy snapshot
but also affectsglooctl proxy dump
andglooctl proxy stats
.Docs changes
TBD
Context
Interesting decisions
The existing code for
dump
andstats
actually would always start hitting the port-forwarded endpoint before the port-forwarding was completed - which would always fail and spam spurious messages. This really needs to be fixed properly by the use of a real Golang kube client, but in the interim we can fix it with stdout scans.Checklist:
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7131