[DNM] test adding slack notification for test summaries #10211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keep pr updated
|
/skip-ci testing gha |
|
Visit the preview URL for this PR (updated for commit 5345d0a): https://gloo-edge--pr10211-jbohanon-test-summar-plmyfbcz.web.app (expires Tue, 05 Nov 2024 14:19:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
nfuden
reviewed
Oct 17, 2024
There was a problem hiding this comment.
I love the output, can we add the job / test name or something?
https://solo-io-corp.slack.com/archives/C0314KESVNV/p1729194404389549
| @@ -37,6 +40,7 @@ runs: | |||
| shell: bash | |||
| run: make go-test | |||
| - name: Summarize tests | |||
| if: ${{ always() }} | |||
There was a problem hiding this comment.
Oh my summarize wasnt always before? woof
jbohanon
added
keep pr updated
|
/kick-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notify in slack for failures in the Kubernetes E2E suites. This uses the test summary output previously added and a modified version of the current slack notification script.
Outstanding
I have not had time to sort out why the template env expansion for
<$PARENT_JOB_URL|$PREAMBLE>is not working, other than that should be about ready.