Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: disable scheduled trivy scans #10414

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

sam-heilbron
Copy link
Contributor

Description

Disable trivy scanner from running

Context

This job is tightly coupled to Solo.io infrastructure (Slack). Currently it reports errors erroneously, so we should disable the job.

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sam-heilbron
Copy link
Contributor Author

/skip-changelog non-functional

Copy link
Contributor

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Do you think we can just delete the slack piece and then have issues opened in this repo?

@yuval-k yuval-k enabled auto-merge (squash) January 8, 2025 14:19
@yuval-k yuval-k disabled auto-merge January 8, 2025 14:41
@yuval-k yuval-k merged commit 8fabb1f into main Jan 8, 2025
8 of 17 checks passed
@yuval-k yuval-k deleted the sh/disable-trivy-scans-3 branch January 8, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants