.github/workflows: Disable permafailing jobs on nightly workflow #10473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <[email protected]>
timflannagan
commented
Jan 17, 2025
|
|
||
| publish_results: |
There was a problem hiding this comment.
Added TODO comment at the top of the workflow in case we want to re-enable this job over time. Right now we don't have a slack channel and it was referencing the internal slack channel.
timflannagan
commented
Jan 17, 2025
There was a problem hiding this comment.
Unrelated to these changes, but I think we could add permissions to this workflow instead of relying on a personal PAT token?
env:
GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} # necessary to pass upgrade tests
jenshu
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables permafailing jobs in the nightly GHA workflow. See #10472 for some context on the state of this workflow. This is a follow-up to #10455 which disabled several jobs on main that haven't been migrated over yet. See #10447 for the tracker for that effort.
Closes #10472.
Checklist: