-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add access logging support #10506
base: main
Are you sure you want to change the base?
[WIP] Add access logging support #10506
Conversation
LogName string `json:"logName,omitempty"` | ||
|
||
// The static cluster defined in bootstrap config to route to | ||
StaticClusterName string `json:"staticClusterName,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does it need to be static?
any chance we can do something like https://github.com/solo-io/gloo/blob/main/projects/gloo/pkg/plugins/als/converter.go#L56-L64 to validate the contents of the access logging itself? |
I'm hesitant to include those initially for a couple of reasons:
Most of the validation should be happening as part of the kubebuilder validation lines. I'm not sure we want to validate on the content of access logs, just the configuration. |
7bf1610
to
9827e53
Compare
Description
#10507
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
Checklist: