Remove skv2 dep in e2e tests #10556
Merged
Remove skv2 dep in e2e tests #10556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timflannagan
approved these changes
Jan 30, 2025
lgadban
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
feels like this entire util package could/should live under test/
There was a problem hiding this comment.
i wasn't sure if it should/could since it's referenced from projects/gateway2/translator/gateway/gateway_translator_test.go too
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a couple of util funcs from skv2 that can be moved into this repo