initial TLSRoute support #10648
Merged
initial TLSRoute support #10648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtomontt/tls-route
…ertomontt/tls-route
…ertomontt/tls-route
5 tasks
yuval-k
reviewed
Feb 26, 2025
| var hostnames []string | ||
| if l == nil || hr == nil { | ||
| if l == nil { |
There was a problem hiding this comment.
should we check len(hr) == 0 here? (not sure, asking because there was a conditional before)
There was a problem hiding this comment.
no, because empty list is treated as "select all" . So I maintained that behavior. Later we check :
if len(routeHostnames) == 0 {
return true, []string{listenerHostname}
}
| routeInfos []*query.RouteInfo, | ||
| reporter reports.ListenerReporter, | ||
| ) { | ||
| var validRouteInfos []*query.RouteInfo |
There was a problem hiding this comment.
can you add a yaml tests for that in https://github.com/kgateway-dev/kgateway/blob/main/internal/kgateway/translator/gateway/gateway_translator_test.go ?
can this be unit-tested as well?
shashankram
reviewed
Feb 26, 2025
…ertomontt/tls-route
…ertomontt/tls-route
…ertomontt/tls-route
…ertomontt/tls-route
…ertomontt/tls-route
…ertomontt/tls-route
yuval-k
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crossport of solo-io#10601
Adds initial support for TLSRoutes. TLSRoutes are similar to TCPRoutes, but the distinction between them is that TLSRoutes allows routing decisions by SNI. See docs.
This PR adds support for TLS Passthrough on a TLS listener using a TLSRoute.
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
Checklist: