Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Scatter struct nulls when deserializing Presto wire format (facebooki…
…ncubator#8318) Summary: When reading spill serialization, struct nulls are written before the struct columns and the reading can proceed i a single pass. Like this, nulls from enclosing structs are passed down when reading. These are combined ith nulls of the contained column so that the contained column also has a null for rows where the enclosing struct is null. When reading Presto Pages, struct nulls come after the child columns. A separate pass scatters the child column values so as to create a null gap for the rows where the containing struct is null. Adds a test for encoding preserving roud trips. Adds a test for concatenating different encodings in a message, e.g. constant, dictionary, flat in all combinations of same/different encoding/value domain. This functionality only applies to nulls first representations. This will apply to Presto pages when the struct nulls are read before constructing the struct. See PR 8152 for the end state. Pull Request resolved: facebookincubator#8318 Reviewed By: xiaoxmeng Differential Revision: D52682198 Pulled By: oerling fbshipit-source-id: 4253727392ecae2caca92e79799710703370a287
- Loading branch information