Limit HTTP proxy listen address + add real_ip_header config option #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP proxy should respect IPv4 address set in configuration and not listen on 0.0.0.0 so it won't interfere with other daemons listening on the same port on different (specific) IP address.
When Evilginx is running behind a reverse HTTP proxy, the information on client IP address is lost. The client with IP address A.A.A.A connects to proxy at B.B.B.B, which then makes connection to Evilginx at C.C.C.C. The client IP address in Evilginx is determined from source address of the TCP connection and so B.B.B.B is logged and used in blacklist instead of A.A.A.A. The new config option
real_ip_header
adds possibility to read information on original client IP address from a specified HTTP header set by the reverse HTTP proxy (e.g. "X-Forwarded-For")