Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utils] 공용 유틸리티 추가 #169

Merged
merged 2 commits into from
Jun 18, 2024
Merged

[Utils] 공용 유틸리티 추가 #169

merged 2 commits into from
Jun 18, 2024

Conversation

gwansikk
Copy link
Member

Summary

#153

모노레포 전역에서 자주 사용하는 공용 유틸리티를 추가했어요.

Tasks

이제는 아래 함수는 @clab/utils에서 가져와 사용할 수 있어요.

  • cn
  • createURL
  • createPagination
  • formatWon
  • formatComma
  • toDecodeHTMLEntities
  • isObjectsEqual
  • getRandomNumber

ETC

현재 구현된 유틸에 대한 테스트 코드도 작성했어요.

image

@gwansikk gwansikk added 🔨 Refactor 코드 수정 및 최적화 🏠 Member member 프로젝트 관련 ⏰ Time time 프로젝트 관련 🧩 DesignSystem design-system 프로젝트 관련 🔒 Auth auth 프로젝트 관련 📦 Utils utils 패키지 관련 labels Jun 18, 2024
@gwansikk gwansikk self-assigned this Jun 18, 2024
@gwansikk gwansikk linked an issue Jun 18, 2024 that may be closed by this pull request
2 tasks
Copy link

changeset-bot bot commented Jun 18, 2024

⚠️ No Changeset found

Latest commit: b0056b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 89.42308% with 11 lines in your changes missing coverage. Please review.

Project coverage is 49.55%. Comparing base (5297beb) to head (b0056b5).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   40.83%   49.55%   +8.72%     
==========================================
  Files          12       14       +2     
  Lines         573      680     +107     
  Branches       26       41      +15     
==========================================
+ Hits          234      337     +103     
- Misses        332      336       +4     
  Partials        7        7              
Files Coverage Δ
packages/design-system/src/Button/Button.tsx 100.00% <100.00%> (ø)
packages/design-system/src/Input/Input.tsx 100.00% <100.00%> (ø)
packages/design-system/src/OTPInput/OTPInput.tsx 88.23% <100.00%> (ø)
packages/design-system/src/Spinner/Spinner.tsx 100.00% <100.00%> (ø)
packages/utils/src/math.ts 100.00% <100.00%> (ø)
packages/utils/src/object.ts 100.00% <ø> (ø)
packages/utils/src/string.ts 100.00% <100.00%> (ø)
packages/design-system/src/Checkbox/Checkbox.tsx 0.00% <0.00%> (ø)
...ages/design-system/src/DetailsList/DetailsList.tsx 0.00% <0.00%> (ø)
packages/design-system/src/Table/Table.tsx 0.00% <0.00%> (ø)
... and 4 more

@gwansikk gwansikk merged commit d2e1206 into main Jun 18, 2024
6 checks passed
@gwansikk gwansikk deleted the feature/#153 branch June 18, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔒 Auth auth 프로젝트 관련 🧩 DesignSystem design-system 프로젝트 관련 🏠 Member member 프로젝트 관련 🔨 Refactor 코드 수정 및 최적화 ⏰ Time time 프로젝트 관련 📦 Utils utils 패키지 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Utils] 공용 유틸리티 추가
1 participant