Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon, ds패키지 빌드 개선과정 중 ci 에러 수정 #190

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

SWARVY
Copy link
Contributor

@SWARVY SWARVY commented Jul 30, 2024

Summary

#183 icon 컴포넌트 생성 건너뛰기

  • 어제 올렸던 PR에서 발생했던 ci 에러를 수정했습니다.

Tasks

  • icon에 존재하던 renew.bash에 누락된 shebang 구문 추가

@SWARVY SWARVY added 🐞 Bug 버그 명세 및 수정 🎨 Icon icon 패키지 관련 labels Jul 30, 2024
@SWARVY SWARVY self-assigned this Jul 30, 2024
@SWARVY SWARVY requested a review from Jeong-Ag as a code owner July 30, 2024 05:05
Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: c7e7925

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.06%. Comparing base (f030f6c) to head (c7e7925).
Report is 7 commits behind head on main.

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files          14       14           
  Lines         219      219           
  Branches       37       37           
=======================================
  Hits          206      206           
  Misses         11       11           
  Partials        2        2           

@gwansikk gwansikk self-requested a review July 30, 2024 05:12
Copy link
Member

@gwansikk gwansikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@gwansikk gwansikk merged commit 7c4df1c into main Jul 30, 2024
6 checks passed
@gwansikk gwansikk deleted the fix/#183 branch July 30, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug 버그 명세 및 수정 🎨 Icon icon 패키지 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants