-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
타임서비스 이름 변경 및 타임테이블 모달 내부 요소 추가 #199
Conversation
… on inner element click (#97)
|
@SWARVY conflicts 확인 부탁드려요 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~ 🙌
const [selectedRegion, setSelectedRegion] = useState<Region[]>([ | ||
REGION.campus1, | ||
REGION.campus2, | ||
]); | ||
const [selectedGrade, setSelectedGrade] = useState<Grade[]>([]); | ||
const [selectedDay, setSelectedDay] = useState<DayKor[]>([day]); | ||
const [selectedPeriod, setSelectedPeriod] = useState< | ||
DayPeriod[] | NightPeriod[] | ||
>([period]); | ||
const [selectedLectureType, setSelectedLectureType] = useState<LectureKey[]>( | ||
[], | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useState 하나로 묶어서 관리하기엔 어려움이 있을까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그냥 객체로 수정하면 안될 것 같고, useReducer
를 사용하여 state를 관리하는 방법에 대해서 고민해보도록 하겠습니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 State는 복잡성이 높기 때문에useReducer
로 구현할 경우 코드량이 더욱 많아지고 이해하기 힘들 수도 있을 거 같아요, 현재 상태로 유지하다가 추후에 더 복잡성을 가지게 될 때 리팩토링을 하는 방향도 좋을 거 같습니다
Summary
#97 TimeTable Page 개발
Tasks
ETC
Screenshot