feat(time): TimeTable Modal 추가기능 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -> `NEXT_PUBLIC_SERVER_URL`
|
gwansikk
approved these changes
Aug 19, 2024
| }); | ||
| const lectureList = data.data.values; | ||
|
|
||
| return ( | ||
| <> |
| )} | ||
| </tr> | ||
| )} | ||
| </tbody> | ||
| </> |
| @@ -229,7 +229,7 @@ const TimeTableModalMajorInput = memo(function TimeTableModalMajorInput({ | |||
| selectedMajor, | |||
| handleMajorInputChange, | |||
| }: TimeTableModalMajorInputProps) { | |||
| const [inputValue, setInputValue] = useState(''); | |||
| const [inputValue, setInputValue] = useState<string>(''); | |||
There was a problem hiding this comment.
Suggested change
| const [inputValue, setInputValue] = useState<string>(''); | |
| const [inputValue, setInputValue] = useState(''); |
| @@ -229,7 +229,7 @@ const TimeTableModalMajorInput = memo(function TimeTableModalMajorInput({ | |||
| selectedMajor, | |||
| handleMajorInputChange, | |||
| }: TimeTableModalMajorInputProps) { | |||
| const [inputValue, setInputValue] = useState(''); | |||
| const [inputValue, setInputValue] = useState<string>(''); | |||
| const [open, setOpen] = useState<boolean>(false); | |||
There was a problem hiding this comment.
Suggested change
| const [open, setOpen] = useState<boolean>(false); | |
| const [open, setOpen] = useState(false); |
| queryFn: ({ pageParam }) => | ||
| getLectureList({ ...params, cursor: pageParam }), | ||
| initialPageParam: 0, | ||
| select: (data) => (data.pages ?? []).flatMap((page) => page.data.values), |
There was a problem hiding this comment.
Suggested change
| select: (data) => (data.pages ?? []).flatMap((page) => page.data.values), | |
| select: ({ pages = [] }) => pages.flatMap((page) => page.data.values), |
Jeong-Ag
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TimeTableModal에 미구현되었던 기능들을 구현했습니다.Tasks
useInfiniteQuery를 사용하여useLectureList훅 재설계useInfiniteScroll공용 훅 생성Pretendard폰트 적용id가 추가되도록 구현inputValue가 초기화되도록 변경getAPIURL유틸 함수가 정상적으로 URL을 반환하지 못하는 문제 수정ETC
TimeTableLectureTable의thead부분에sticky를 적용했는데, 이거 적용하니까border-y속성이 날아가서 뷰가 조금 부자연스러워 보이는 문제가 있습니다. 해당 문제 해결법 찾아서 수정하도록 하겠습니다.table-auto속성이 적용되어있어서 특정 데이터의 길이에 따라서 특정 카테고리의 영역이 점점 늘어나는 경우가 있는데, 해당 부분에 대해서 고정 사이즈를 적용하기에는 조금 문제가 있어보여서 해당 부분들은 조금 더 좋은 방법을 찾아보도록 하겠습니다.Screenshot