refactor(member): 활동 2차 QA 피드백 반영 수정 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8d3640a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gwansikk
approved these changes
Sep 7, 2024
Comment on lines
-21
to
+44
| {children} | ||
| {name} |
There was a problem hiding this comment.
이전에는 children 으로 p태그를 받아 파일 명을 넣고 있었는데 props로 name을 받아서 단순화 하고자 했어요.
Comment on lines
+29
to
38
| const queryKeys = [ | ||
| ACTIVITY_QUERY_KEY.STATUS(ACTIVITY_STATE.END), | ||
| ACTIVITY_QUERY_KEY.STATUS(ACTIVITY_STATE.PROGRESSING), | ||
| ACTIVITY_QUERY_KEY.STATUS(ACTIVITY_STATE.WAITING), | ||
| ACTIVITY_QUERY_KEY.DETAIL(data), | ||
| ]; | ||
|
|
||
| queryClient.invalidateQueries({ | ||
| queryKey: ACTIVITY_QUERY_KEY.DETAIL(data), | ||
| queryKeys.forEach((queryKey) => { | ||
| queryClient.invalidateQueries({ queryKey }); | ||
| }); |
SWARVY
approved these changes
Sep 8, 2024
Comment on lines
+22
to
+29
| const href = window.URL.createObjectURL(new Blob([blob])); | ||
| const a = document.createElement('a'); | ||
| a.href = href; | ||
| a.download = name; | ||
| document.body.appendChild(a); | ||
| a.click(); | ||
| window.URL.revokeObjectURL(href); | ||
| a.remove(); |
There was a problem hiding this comment.
긴 라인은 문맥을 한번 구분해주는게 가독성에 좋아요
Suggested change
| const href = window.URL.createObjectURL(new Blob([blob])); | |
| const a = document.createElement('a'); | |
| a.href = href; | |
| a.download = name; | |
| document.body.appendChild(a); | |
| a.click(); | |
| window.URL.revokeObjectURL(href); | |
| a.remove(); | |
| const href = window.URL.createObjectURL(new Blob([blob])); | |
| const a = document.createElement('a'); | |
| a.href = href; | |
| a.download = name; | |
| document.body.appendChild(a); | |
| a.click(); | |
| window.URL.revokeObjectURL(href); | |
| a.remove(); |
Comment on lines
+50
to
54
| if (files) { | ||
| Array.from(files).forEach((file) => { | ||
| formData.append(FORM_DATA_KEY, file); | ||
| }); | ||
| } |
There was a problem hiding this comment.
files의 형태가 array같은데 Array.from을 사용하신 이유가 있을까요?
There was a problem hiding this comment.
files가 FileList 형태라서 변환 없이 forEach를 사용하려고 하니 에러가 발생하여 Array.from을 사용하였어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
운영진 대상으로 진행된 2차 활동 QA를 바탕으로 코드를 개선합니다.
Tasks
option에 category, leader, name 표시, 선택하지 않은 경우는 미선택option설정badge추가, 나의 지원 탭 삭제modal크기 조정ETC
피드백 사항이 많아서 1차 PR 먼저 올립니다. 남은 사항은 서버 수정사항 확인 후 작업하여 추가 PR 하도록 하겠습니다.
이슈도
notion에 작성된 내용 확인 후 업데이트 하도록 하겠습니다.Screenshot