Merge pull request #2 from khanakbhargava/revert-1-wdmerger_test

Revert "Wdmerger test"
khanakbhargava · Mar 18, 2024 · a1c91d5 · a1c91d5
2 parents 5830f6a + b213567
commit a1c91d5
Show file tree

Hide file tree

Showing 303 changed files with 118,544 additions and 144,794 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -7,6 +7,7 @@ Checks: >
      clang-diagnostic-*,
      cppcoreguidelines-*,
        -cppcoreguidelines-avoid-c-arrays,
+       -cppcoreguidelines-avoid-goto,
        -cppcoreguidelines-avoid-magic-numbers,
        -cppcoreguidelines-avoid-non-const-global-variables,
        -cppcoreguidelines-init-variables,
@@ -16,17 +17,11 @@ Checks: >
        -cppcoreguidelines-non-private-member-variables-in-classes,
        -cppcoreguidelines-owning-memory,
        -cppcoreguidelines-pro-*,
-     misc-*,
-       -misc-const-correctness,
-       -misc-include-cleaner,
-       -misc-non-private-member-variables-in-classes,
      modernize-*,
        -modernize-avoid-c-arrays,
        -modernize-use-trailing-return-type,
        -modernize-use-using,
      performance-*,
-       -performance-avoid-endl,
-     portability-*,
      readability-*,
        -readability-avoid-const-params-in-decls,
        -readability-braces-around-statements,

diff --git a/.github/dependabot.yml b/.github/dependabot.yml
diff --git a/.github/workflows/c-linter.yml b/.github/workflows/c-linter.yml
@@ -6,7 +6,7 @@ jobs:
   cpp-linter:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -30,7 +30,7 @@ jobs:
           tar xfz v2.28.0.tar.gz
           cd hypre-2.28.0/src
           ./configure --with-cxxstandard=17 --without-MPI
-          make -j 4
+          make -j 2
           make install
           cd ../../
 
@@ -56,7 +56,7 @@ jobs:
           -run-linter
 
       - name: Archive clang tidy report
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v3
         with:
           name: clang-tidy-report
           path: clang-tidy-report.txt
diff --git a/.github/workflows/check-ifdefs.yml b/.github/workflows/check-ifdefs.yml
@@ -14,14 +14,23 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v4
         with:
-          python-version: '3.11'
+          python-version: '3.10'
+
+      - name: Cache pip
+        uses: actions/cache@v3
+        with:
+          # this path is specific to Ubuntu
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
 
       - name: Run check-ifdefs
         run: |

diff --git a/.github/workflows/check-makefiles.yml b/.github/workflows/check-makefiles.yml
@@ -19,9 +19,18 @@ jobs:
           fetch-depth: 0
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v4
         with:
-          python-version: '3.11'
+          python-version: '3.10'
+
+      - name: Cache pip
+        uses: actions/cache@v3
+        with:
+          # this path is specific to Ubuntu
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
 
       - name: Run check-ifdefs
         run: |

diff --git a/.github/workflows/check-params.yml b/.github/workflows/check-params.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -28,10 +28,19 @@ jobs:
           cd ../..
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v4
         with:
           python-version: '3.11'
 
+      - name: Cache pip
+        uses: actions/cache@v3
+        with:
+          # this path is specific to Ubuntu
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
+
       - name: Run check-params
         run: |
           PYTHONPATH=external/Microphysics/util/build_scripts python .github/workflows/check_params.py .
diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml
@@ -14,15 +14,23 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v4
         with:
           python-version: '3.10'
-          cache: "pip"
+
+      - name: Cache pip
+        uses: actions/cache@v3
+        with:
+          # this path is specific to Ubuntu
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
 
       - name: Install dependencies
         run: pip install -r ./requirements.txt

diff --git a/.github/workflows/compiler-warnings.yml b/.github/workflows/compiler-warnings.yml
@@ -5,7 +5,7 @@ jobs:
   compiler_warnings:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -26,14 +26,14 @@ jobs:
       - name: Compile Detonation
         run: |
           cd Exec/science/Detonation
-          make USE_MPI=FALSE USE_OMP=FALSE DEBUG=TRUE WARN_ALL=TRUE WARN_ERROR=TRUE -j 4
+          make USE_MPI=FALSE USE_OMP=FALSE DEBUG=TRUE WARN_ALL=TRUE WARN_ERROR=TRUE -j 2
 
       - name: Compile subchandra
         run: |
           cd Exec/science/subchandra
-          make USE_MPI=FALSE USE_OMP=FALSE DEBUG=TRUE WARN_ALL=TRUE WARN_ERROR=TRUE -j 4
+          make USE_MPI=FALSE USE_OMP=FALSE DEBUG=TRUE WARN_ALL=TRUE WARN_ERROR=TRUE -j 2
 
       - name: Compile wdmerger
         run: |
           cd Exec/science/wdmerger
-          make USE_MPI=FALSE USE_OMP=FALSE DEBUG=TRUE WARN_ALL=TRUE WARN_ERROR=TRUE -j 4
+          make USE_MPI=FALSE USE_OMP=FALSE DEBUG=TRUE WARN_ALL=TRUE WARN_ERROR=TRUE -j 2
diff --git a/.github/workflows/create_release.yml b/.github/workflows/create_release.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
 
       - name: Get the version
         id: get_version
@@ -33,4 +33,4 @@ jobs:
           release_name: Release ${{ github.ref }}
           body: ${{ env.RELEASE_TXT }}
           draft: false
-          prerelease: false
+          prerelease: false
diff --git a/.github/workflows/dependencies_hip.sh b/.github/workflows/dependencies_hip.sh
@@ -1,26 +1,17 @@
 #!/usr/bin/env bash
 #
-# Copyright 2020 The AMReX Community
+# Copyright 2020-2022 The AMReX Community
 #
 # License: BSD-3-Clause-LBNL
 # Authors: Axel Huebl
 
-# search recursive inside a folder if a file contains tabs
-#
-# @result 0 if no files are found, else 1
-#
-
 set -eu -o pipefail
 
-# `man apt.conf`:
-#   Number of retries to perform. If this is non-zero APT will retry
-#   failed files the given number of times.
-echo 'Acquire::Retries "3";' | sudo tee /etc/apt/apt.conf.d/80-retries
 
 # Ref.: https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#ubuntu
 curl -O https://repo.radeon.com/rocm/rocm.gpg.key
 sudo apt-key add rocm.gpg.key
-echo "deb [arch=amd64] https://repo.radeon.com/rocm/apt/${1-debian}/ ubuntu main" \
+echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/debian/ ubuntu main' \
   | sudo tee /etc/apt/sources.list.d/rocm.list
 echo 'export PATH=/opt/rocm/llvm/bin:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/rocm/opencl/bin:$PATH' \
   | sudo tee -a /etc/profile.d/rocm.sh
@@ -43,14 +34,12 @@ sudo apt-get install -y --no-install-recommends \
     roctracer-dev   \
     rocprofiler-dev \
     rocrand-dev     \
-    rocprim-dev     \
-    hiprand-dev
+    rocprim-dev
 
 # activate
 #
 source /etc/profile.d/rocm.sh
 hipcc --version
-hipconfig --full
 which clang
 which clang++
 which flang
diff --git a/.github/workflows/detonation-sdc-compare.yml b/.github/workflows/detonation-sdc-compare.yml
@@ -5,7 +5,7 @@ jobs:
   detonation-sdc:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -26,7 +26,7 @@ jobs:
       - name: Compile Detonation
         run: |
           cd Exec/science/Detonation
-          make DIM=1 USE_MPI=FALSE -j 4 USE_SIMPLIFIED_SDC=TRUE
+          make DIM=1 USE_MPI=FALSE -j 2 USE_SIMPLIFIED_SDC=TRUE
 
       - name: Run Detonation
         run: |
@@ -36,7 +36,7 @@ jobs:
       - name: Build the fextrema tool
         run: |
           cd external/amrex/Tools/Plotfile
-          make programs=fextrema -j 4
+          make programs=fextrema -j 2
 
       - name: Check the extrema
         run: |

diff --git a/.github/workflows/docs-test.yml b/.github/workflows/docs-test.yml
@@ -9,38 +9,39 @@ on:
     branches:
       - development
 
-env:
-  # enable color output from Sphinx
-  FORCE_COLOR: "1"
-
 jobs:
   docs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - name: Install pandoc and doxygen
         run: |
           sudo apt install pandoc doxygen
 
       - name: Setup Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v4
+        with:
+          python-version: '3.10'
+
+      - name: Cache pip
+        uses: actions/cache@v3
         with:
-          python-version: '3.11'
-          cache: "pip"
+          # this path is specific to Ubuntu
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
 
       - name: Install dependencies
         run: pip install -r ./requirements.txt
 
       - name: Build docs
         run: |
           cd Docs/
-          # remove missing TOC entries that would otherwise be generated by
-          # doxygen to avoid warnings about missing references
-          sed -i -e 's/^   filelist$//; s/^   classlist$//' source/index.rst
-          make SPHINXOPTS='-v -W --keep-going' NO_DOXYGEN=TRUE html
+          make SPHINXOPTS=-v NO_DOXYGEN=TRUE html
 
       - name: Check links
         run: |

diff --git a/.github/workflows/exact_riemann.yml b/.github/workflows/exact_riemann.yml
@@ -5,7 +5,7 @@ jobs:
   exact_riemann:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/flame_wave-compare.yml b/.github/workflows/flame_wave-compare.yml
@@ -5,7 +5,7 @@ jobs:
   flame_wave-2d:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/get_release_txt.py b/.github/workflows/get_release_txt.py
@@ -26,9 +26,9 @@
                     txt = txt[m.end():].strip()
             else:
                 txt = ""
-
-            # we now need to substitute characters in the string so that
-            # the action can deal with line breaks
+                    
+            # we now need to substitute characters in the string so that 
+            # the action can deal with line breaks 
             txt = txt.replace('%', '%25')
             txt = txt.replace('\n', '%0A')
             txt = txt.replace('\r', '%0D')