Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom heuristics #213

Open
kaitj opened this issue Feb 26, 2024 · 1 comment · May be fixed by #216
Open

Custom heuristics #213

kaitj opened this issue Feb 26, 2024 · 1 comment · May be fixed by #216
Assignees

Comments

@kaitj
Copy link
Collaborator

kaitj commented Feb 26, 2024

Currently heuristics are saved within a private repository. This requires admins to create and maintain custom heuristics, while also making the conversion a bit of a black-box to the end-user. If we want to shift onus of maintaining studies more to the end-user, there can be a two-stage implementation to change the current workflow.

  1. As a stop-gap, move the heuristics to a public repo, behind a protected branch. This will allow users to make changes or add new heuristics via pull request, lessening the burden on admin. Admin will still need to be accept and merge in pull requests. Heuristics are pulled automatically once a day, or alternatively, admins can trigger a heuristic update via the admin page.
  2. Refactor the use of heuristics similar to the .bidsignore contents. That is, add a column to the study table in the database saving a default heuristic (cfmm_base?). Under the study config, the user can then edit this study config and each time tar2bids is called, the heuristic is written to a temporary file.

With (2), the user will have to maintain their own heuristics. Ideally, there would be a guide for this (on CBS Discourse?). Would need to think around how users can get access to the heudiconv generated files to aid with the mapping if necessary. Alternatively, could users get access to DICOM values from the DICOM server?

@kaitj
Copy link
Collaborator Author

kaitj commented Feb 27, 2024

The autobids portal has been updated to use (1) now.

(2) is implemented in a PR - pending discussion about switch.

@kaitj kaitj linked a pull request Feb 27, 2024 that will close this issue
@kaitj kaitj self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant